Refactor something that 's not quite a Template pattern

Google

Mailing List

Home

Forum Home

JBoss - Java Application Server

Tomcat - JSP/Servlet container

Struts - A MVC web framework

iText - An open source PDF Java Library

JDOM - JDOM XML Parser

JSP - A mailing list about Java Server Pages specification and reference

J2EE - A mailing list for Java(tm) 2 Platform, Enterprise Edition

J2EE Pattern - An interest list for Sun Java Center J2EE Pattern Catalog

Servlet - A mailing list for discussion about Sun Microsystem's Java Servlet API Technology

Struts & Hibernate

Subjects

•	JSP editor plugin for eclipse ?
•	org apache jasper JasperException: Unable to compile class for JSP
•	Tomcat: Connection reset by peer: socket write error
•	Cannot retrieve definition for form bean null
•	Struts Tiles Tutorial (free Struts training)
•	Where do I download Tomcat 4 0 6?
•	Data Access Object (DAO) pattern, example DAO 's
•	Where to download Tomcat v 4 1 24 from?
•	Tomcat 5 0 16 Requested resource not available
•	Subject: Servlet : Session invalidate
•	Oracle Connection Pooling in 3 2 2
•	Servlet action is currently unavailable
•	Tomcat/Struts Unicode Encoding/Decoding problems
•	Subject: Running a Simple JMS Example
•	Tomcat and webapplication specific java library path
•	Mapping in workers2 properties
•	org apache jasper JasperException
•	problem with html:text bean throwing exception
•	Cannot find message resources under key org apache struts action MESSAGE
•	Cannot find message resources under key org apache struts action MESSAGE
•	invalid direct reference problem with solution
•	Tool for jsp debug Try Sysdeo Eclipse Plugin
•	Tomcat 5 Cannot load JDBC driver class 'null ' SQL state: null
•	weblogic ejbc
•	java properties file
•	Jboss 3 2 3 Coyote Can 't re
•	Tomcat 5, Apache2 and mod jk2 integration problem
•	JBoss example problem new to J2EE
•	Value attribute of <html:checkbox
•	url string for connecting jboss to oracle
•	javax servlet ServletException: BeanUtils populate
•	5 0 18: Windows XP Pro vs Windows 2000
•	HTTP Status 404 The requested resource is not available

Refactor something that 's not quite a Template pattern

Refactor something that 's not quite a Template pattern

2006-08-25 - By snekse

Back

Reply: 1 2 3 4

That misses a step. I need to split which fetch method it's going to call
if the cached list is null.

i.e.

lCacheList = MiscCodeDao.fetchList_A(pSession);
-OR-
lCacheList = MiscCodeDao.fetchList_B(pSession);

On 8/25/06, Dan Marchant <driedtoast@(protected)> wrote:
>
> why don't you just do this:
>
>
>
> public static List fetchList(String key, Session pSession)
> throws HibernateException
> {
> String lListKey = key;
> List lCacheList = (List) getObjectValueOrNull(MISC_LISTS_CACHE
> .get(lListKey));
>
> if(lCacheList==null)
> {
> lCacheList = MiscCodeDao.fetchList_A(pSession);
> MISC_LISTS_CACHE.put(new Element(lListKey,lCacheList));
> }
> return lCacheList;
> }
>
>
> public static List fetchList_A(Session pSession)
> throws HibernateException
> {
> String lListKey = "LIST_A";
> return fetchList(IListKey,pSession);
> }
>
> public static List fetchList_B(Session pSession)
> throws HibernateException
> {
> String lListKey = "LIST_B";
> return fetchList(IListKey,pSession);
> }
>
> - dan
>
> On 8/25/06, snekse <snekse@(protected)> wrote:
> > Can anyone point me to a good way to refactor this? Currently these two
> > methods do exactly the same thing, except they use a different param as
> the
> > obj key ( lListKey ) and if it's not found in the cache, they need to
> call
> > separate methods ( MiscCodeDao.fetch*(..) ) to retrieve the object so it
> can
> > put it into the cache.
> >
> >
> > public static List fetchList_A(Session pSession)
> > throws HibernateException
> > {
> > String lListKey = "LIST_A";
> > List lCacheList = (List) getObjectValueOrNull(MISC_LISTS_CACHE
> > .get(lListKey));
> >
> > if(lCacheList==null)
> > {
> > lCacheList = MiscCodeDao.fetchList_A(pSession);
> > MISC_LISTS_CACHE.put(new Element(lListKey,lCacheList));
> > }
> > return lCacheList;
> > }
> >
> > public static List fetchList_B(Session pSession)
> > throws HibernateException
> > {
> > String lListKey = "LIST_B";
> > List lCacheList = (List)
> > getObjectValueOrNull(MISC_LISTS_CACHE.get(lListKey));
> >
> > if(lCacheList==null)
> > {
> > lCacheList = MiscCodeDao.fetchList_B(pSession);
> > MISC_LISTS_CACHE.put(new Element(lListKey,lCacheList));
> > }
> > return lCacheList;
> > }
> >
> > The reason I want to refactor this is because we are going to have 10-20
> > list stored in the cache. Here's the rub: I need to avoid hardcoding a
> > string for the method name (i.e.
> > invokeMethod("fetchList_A",MiscCodeDao.class, paramArray) ). We've found
> > issues with refactoring when the method names are hardcoded as a String
> > variable. If possible, I'd also like to avoid a switch as well (i.e.
> > fetchList("LIST_A") )
> >
> > Any thoughts?
> >
> > Thanks,
> > snekse
> > ====================================================================
> > Companion Site: http://www.corej2eepatterns.com J2EE BluePrints:
> > http://java.sun.com/blueprints/corej2eepatterns List
> > Archive:
> > http://archives.java.sun.com/archives/j2eepatterns-interest.html
> > Unsubscribing: email "signoff J2EEPATTERNS-INTEREST" to
> > listserv@(protected)
>
> ====================================================================
> Companion Site: http://www.corej2eepatterns.com
> J2EE BluePrints: http://java.sun.com/blueprints/corej2eepatterns
> List Archive:
> http://archives.java.sun.com/archives/j2eepatterns-interest.html
> Unsubscribing: email "signoff J2EEPATTERNS-INTEREST" to
> listserv@(protected)
>

====================================================================
Companion Site: http://www.corej2eepatterns.com
J2EE BluePrints: http://java.sun.com/blueprints/corej2eepatterns
List Archive: http://archives.java.sun.com/archives/j2eepatterns-interest.html
Unsubscribing: email "signoff J2EEPATTERNS-INTEREST" to listserv@(protected)

That misses a step.  I need to split which fetch method it's going to call
if the cached list is null. i.e. lCacheList = MiscCodeDao
.fetchList_A(pSession); -OR- lCacheList = MiscCodeDao.fetchList_B(pSession
);
 <div>On 8/25/06, Dan Marchant <<a href="mailto:driedtoast@(protected)">driedtoast@(protected)
</a>> wrote:<blockquote class="gmail_quote" style="border-left: 1px
solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
why don't you just do this: public static List fetchList(String
key, Session pSession)     throws HibernateException 
    {        &nbsp
;String lListKey = key;         List
lCacheList = (List) getObjectValueOrNull(MISC_LISTS_CACHE
 .get(lListKey));         if
(lCacheList==null)         { &nbsp
;           lCacheList =
MiscCodeDao.fetchList_A(pSession);       &nbsp
;     MISC_LISTS_CACHE.put(new Element(lListKey
,lCacheList));         }  
       return lCacheList;
     } public static List fetchList_A(Session
pSession)     throws HibernateException   
  {         String lListKey
= "LIST_A";         return
fetchList(IListKey,pSession);     } 
     public static List fetchList_B(Session pSession)     throws HibernateException     {
         String lListKey = "LIST
_B";         return fetchList
(IListKey,pSession);     } - dan 
 On 8/25/06, snekse <<a href="mailto:snekse@(protected)">snekse@(protected)<
/a>> wrote: > Can anyone point me to a good way to refactor this? 
 Currently these two > methods do exactly the same thing, except they
use a different param as the
 > obj key ( lListKey ) and if it's not found in the cache, they need to
call > separate methods ( MiscCodeDao.fetch*(..) ) to retrieve the object
so it can > put it into the cache. > > >  
   public static List fetchList_A(Session pSession)
 >     throws HibernateException >  
   { >         String
lListKey = "LIST_A"; >      &nbsp
;  List lCacheList = (List) getObjectValueOrNull(MISC_LISTS_CACHE >
.get(lListKey)); > 
>         if(lCacheList==null) 
>         { >   
          lCacheList = MiscCodeDao
.fetchList_A(pSession); >        
     MISC_LISTS_CACHE.put(new Element(lListKey,lCacheList));
 >         } >  
       return lCacheList;
 >     } > >    
public static List fetchList_B(Session pSession) >   &nbsp
; throws HibernateException >     { > &nbsp
;       String lListKey = "LIST_B"; 
>         List lCacheList = (List)
 > getObjectValueOrNull(MISC_LISTS_CACHE.get(lListKey)); > >
         if(lCacheList==null) >
         { >   
          lCacheList = MiscCodeDao
.fetchList_B(pSession); >        
     MISC_LISTS_CACHE.put(new Element(lListKey,lCacheList));
 >         } >  
       return lCacheList; >  &nbsp
;  } > > The reason I want to refactor this is because we are
going to have 10-20 > list stored in the cache.  Here's the rub
: I need to avoid hardcoding a
 > string for the method name (i.e. > invokeMethod("fetchList
_A",MiscCodeDao.class, paramArray) ). We've found > issues with
refactoring when the method names are hardcoded as a String > variable.
  If possible, I'd also like to avoid a switch as well (
i.e. > fetchList("LIST_A") ) > >  Any
thoughts? > > Thanks, > snekse > ======================
============================================== > Companion Site: <a href=
"http://www.corej2eepatterns.com">
http://www.corej2eepatterns.com</a> J2EE BluePrints: > <a href="http:/
/java.sun.com/blueprints/corej2eepatterns">http://java.sun.com/blueprints
/corej2eepatterns</a> List > Archive: > <a href="http://archives
.java.sun.com/archives/j2eepatterns-interest.html">
http://archives.java.sun.com/archives/j2eepatterns-interest.html</a> >
Unsubscribing: email "signoff J2EEPATTERNS-INTEREST" to > <a
href="mailto:listserv@(protected)">listserv@(protected)</a> 
==================================================================== Companion Site: <a href="http://www.corej2eepatterns.com">http://www
.corej2eepatterns.com</a> J2EE BluePrints: <a href="http://java.sun.com
/blueprints/corej2eepatterns">
http://java.sun.com/blueprints/corej2eepatterns</a> List Archive: <a href=
"http://archives.java.sun.com/archives/j2eepatterns-interest.html">http:/
/archives.java.sun.com/archives/j2eepatterns-interest.html</a> Unsubscribing:
email "signoff J2EEPATTERNS-INTEREST" to
<a href="mailto:listserv@(protected)">listserv@(protected)</a> <
/blockquote></div> 
====================================================================
Companion Site: http://www.corej2eepatterns.com
J2EE BluePrints: http://java.sun.com/blueprints/corej2eepatterns
List Archive: http://archives.java.sun.com/archives/j2eepatterns-interest.html
Unsubscribing: email "signoff J2EEPATTERNS-INTEREST" to listserv@(protected)